On Tue, Jul 10, 2018 at 08:30:04PM +0200, Daniel Borkmann wrote: > Hi Russell, > > thanks a lot for your work on the arm32 JIT! > > On 07/10/2018 02:36 PM, Russell King wrote: > > Enumerate the contents of the JIT scratch stack layout used for storing > > some of the JITs 64-bit registers, tail call counter and AX register. > > > > XXX: what about the skb_copy_bits buffer - this appears to overlap with > > the first word of the JITs accessible stack. > > Could you elaborate on that case? Unless I'm missing something there should > be no use of the skb_copy_bits buffer anymore (aka former SKB_BUFFER at > STACK_VAR(SCRATCH_SIZE) offset), but aside from that it's not supposed to > overlap either.
Probably an old comment - these were originally developed back in January timeframe when there was the SKB_BUFFER stuff, but that was removed during the 4.18 merge window. I'll kill the comment. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up
