> -----Original Message----- > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > Sent: Tuesday, July 10, 2018 1:32 PM > To: Keller, Jacob E <jacob.e.kel...@intel.com> > Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>; Eric Dumazet > <eduma...@google.com> > Subject: Re: [net] sch_fq_codel: zero q->flows_cnt when fq_codel_init fails > > On Mon, Jul 9, 2018 at 8:37 AM Jacob Keller <jacob.e.kel...@intel.com> wrote: > > +alloc_failure: > > + kfree(q->flows); > > You need to call kvfree() instead. > > Other than this, > > Acked-by: Cong Wang <xiyou.wangc...@gmail.com> > > For net-next, I will send a patch to skip ->reset() for ->init() failure > case, there is no reason to reset queues since qdisc is not even > activated.
Thanks, I sent a v2. Regards, Jake
