On Mon, Jul 09, 2018 at 01:29:11PM +0300, Vlad Buslov wrote: > Extend struct tcf_walker with additional 'cookie' field. It is intended to > be used by classifier walk implementations to continue iteration directly > from particular filter, instead of iterating 'skip' number of times. > > Change flower walk implementation to save filter handle in 'cookie'. Each > time flower walk is called, it looks up filter with saved handle directly > with idr, instead of iterating over filter linked list 'skip' number of > times. This change improves complexity of dumping flower classifier from > quadratic to linearithmic. (assuming idr lookup has logarithmic complexity) > > Reviewed-by: Jiri Pirko <j...@mellanox.com> > Signed-off-by: Vlad Buslov <vla...@mellanox.com>
Reported-by: Simon Horman <simon.hor...@netronome.com> Thanks, I'm very pleased to see this change. I would appreciate it if we could have a little time to test its impact on performance thoroughly. One question: will this work as expected (i.e. be at least backwards compatible) with existing user-space code?
