On 07/06/2018 06:15 PM, Sowmini Varadhan wrote:
On (07/06/18 17:08), Ka-Cheong Poon wrote:
Hmm. Why do you need to include tcp header in ib transport
code ? If there is any common function just move to core
common file and use it.
I think it can be removed as it is left over from earlier
changes when the IB IPv6 listener port was RDS_TCP_PORT.
Now all the port definitions are in rds.h.
Transport specific information such as port numbers should not
be smeared into the common rds-module. Please fix that.
If IB is also piggybacking on port 16385 (why?), please use your
own definitions for it in IB specific header files.
As mentioned in a previous mail, it is unclear why the
port number is transport specific. Most Internet services
use the same port number running over TCP/UDP as shown
in the IANA database. And the IANA RDS registration is
the same. What is the rationale of having a transport
specific number in the RDS implementation?
--
K. Poon
ka-cheong.p...@oracle.com
