Hello Andrew, On Fri, 29 Jun 2018 15:43:43 +0200 Andrew Lunn <and...@lunn.ch> wrote:
>> Thanks for the suggestion. I see how this can be done with >> phydrv->supported and phydev->lp_advertising, however I'm not sure how >> we should deal with the fact that ethernet drivers directly access >> fields such as "advertising" or "supported". > >Hi Maxime > >I started cleaning up some of the MAC drivers. Take a look at > >https://github.com/lunn/linux.git v4.18-rc1-net-next-phy-cleanup > >That moved a lot of the MAC code into helpers, making it easier to >update. It might make sense to add a couple of more helpers, for what >remains. Wow indeed that will help a lot. Just so that we're in sync, do you plan to add those helpers, or should I take this branch as a base for the conversion and go on ? Thanks for this, Maxime -- Maxime Chevallier, Bootlin (formerly Free Electrons) Embedded Linux and kernel engineering https://bootlin.com