David, How can we support NFS boot if pass the parameters via devlink. Basically this determines what phy to use from device tree.
Chandra ________________________________________ From: David Miller <da...@davemloft.net> Sent: Thursday, June 28, 2018 7:19:05 PM To: Munoz, Carlos Cc: and...@lunn.ch; Hill, Steven; netdev@vger.kernel.org; Chavva, Chandrakala Subject: Re: [PATCH v12 03/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet Nexus External Email From: Carlos Munoz <cmu...@cavium.com> Date: Thu, 28 Jun 2018 14:20:05 -0700 > > > On 06/28/2018 01:41 AM, Andrew Lunn wrote: >> External Email >> >>> +static char *mix_port; >>> +module_param(mix_port, charp, 0444); >>> +MODULE_PARM_DESC(mix_port, "Specifies which ports connect to MIX >>> interfaces."); >>> + >>> +static char *pki_port; >>> +module_param(pki_port, charp, 0444); >>> +MODULE_PARM_DESC(pki_port, "Specifies which ports connect to the PKI."); >> Module parameters are generally not liked. Can you do without them? > > These parameters change the kernel port assignment required by user > space applications. We rather keep them as they simplify the > process. This is actually a terrible user experience. Please provide a way to do this by performing operations on a device object after the driver loads. Use something like devlink or similar if you have to.