From: Gerrit Renker <[EMAIL PROTECTED]> Date: Mon, 9 Oct 2006 10:51:44 +0100
> csum_copy_err: > - UDP_INC_STATS_BH(UDP_MIB_INERRORS); > + UDP_INC_STATS_BH(UDP_MIB_INERRORS, is_udplite); > + UDP_DEC_STATS_BH(UDP_MIB_INDATAGRAMS, is_udplite); I'm not a big fan at all of these "statistic corrections" we're starting to place in various spots. I really don't think it's the end of the world if we count as INDATAGRAMS a packet that we later discover has a bad checksum. There are even some serious issues to consider because we might, for example, count the INDATAGRAMS on a particular cpu, and then find the checksum problem on another cpu and thus be subtracting a different one of the per-cpu instances of this counter. That could make it negative or similar. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
