Replace constant integer with sizeof() to clearly indicate
the destination buffer length in skb_header_pointer() calls.

Reviewed-by: Simon Horman <simon.hor...@netronome.com>
Signed-off-by: Roman Mashak <m...@mojatatu.com>
---
 net/sched/act_pedit.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
index 9c2d8a31a5c5..3b775f54cee5 100644
--- a/net/sched/act_pedit.c
+++ b/net/sched/act_pedit.c
@@ -319,7 +319,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct 
tc_action *a,
                                        goto bad;
                                }
                                d = skb_header_pointer(skb, hoffset + tkey->at,
-                                                      1, &_d);
+                                                      sizeof(_d), &_d);
                                if (!d)
                                        goto bad;
                                offset += (*d & tkey->offmask) >> tkey->shift;
@@ -337,7 +337,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct 
tc_action *a,
                        }
 
                        ptr = skb_header_pointer(skb, hoffset + offset,
-                                                4, &hdata);
+                                                sizeof(hdata), &hdata);
                        if (!ptr)
                                goto bad;
                        /* just do it, baby */
-- 
2.7.4

Reply via email to