Re: [PATCH] tcp: verify the checksum of the first data segment in a new connection

[van der Linden, Frank]

Yeah, true, it's missing INERRS in this case. I'll fix it up a bit.

Frank

On 6/11/18, 4:38 PM, "Eric Dumazet" <eric.duma...@gmail.com> wrote:

    
    
    On 06/11/2018 04:25 PM, van der Linden, Frank wrote:
    > A few comments on this one:
    > 
    > - obviously this is fairly serious, as it can let corrupted data all the 
way up to the application
    
    Sure, although anyone relying on CRC checksum for ensuring TCP data 
integrity
    has big troubles ;)
    
    I would rather have a refined version of this patch doing a "goto 
csum_error" 
    so that we properly increment TCP_MIB_CSUMERRORS and TCP_MIB_INERRS 
    
    Thanks !