On Mon, Jun 11, 2018 at 10:00 AM, Jeff Kirsher <jeffrey.t.kirs...@intel.com> wrote: > > We could mitigate some of these issues by changing fq_codel_init to more > explicitly cleanup after itself when failing. For example, we could > ensure that q->flowcnt was set to 0 so that the loop over each flow in > fq_codel_reset would not trigger. However, this would not prevent a NULL > pointer dereference when attempting to memset the q->backlogs.
Are you saying memset(ptr, 0, 0) is not nop?? :-/ Making q->flows_cnt 0 is simpler and easier to understand.
