On Tue, Oct 03, 2006 at 04:42:53PM -0700, Andrew Morton wrote:

> On Tue, 3 Oct 2006 16:18:44 +0100 (BST)
> "Maciej W. Rozycki" <[EMAIL PROTECTED]> wrote:
> 
> > +   sbmac_state_t           sbm_state;      /* current state */
> 
> argh.
> 
> The reader looks at this and doesn't know if it's an integer, a void*, a
> struct usb_ac_header_descriptor** or what.
> 
>       enum sbmac_state        smb_state;
> 
> is nicer.  It has information.

De-typedef-ing would be a separate project for this driver which makes
quite generous use of typedefs.

  Ralf
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to