[net-next] Revert "ixgbe: release lock for the duration of ixgbe_suspend_close()"

[Jeff Kirsher]

This reverts commit 6710f970d9979d8f03f6e292bb729b2ee1526d0e.

Gotta love when developers have offline discussions, thinking everyone
is reading their responses/dialog.

The change had the potential for a number of race conditions on
shutdown, which is why we are reverting the change.

Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c 
b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 5ddfb93ed491..a52d92e182ee 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -6698,15 +6698,8 @@ static int __ixgbe_shutdown(struct pci_dev *pdev, bool 
*enable_wake)
        rtnl_lock();
        netif_device_detach(netdev);
 
-       if (netif_running(netdev)) {
-               /* Suspend takes a long time, device_shutdown may be
-                * parallelized this function, so drop lock for the
-                * duration of this call.
-                */
-               rtnl_unlock();
+       if (netif_running(netdev))
                ixgbe_close_suspend(adapter);
-               rtnl_lock();
-       }
 
        ixgbe_clear_interrupt_scheme(adapter);
        rtnl_unlock();
-- 
2.17.0