From: Andrea Greco <andrea.greco.gapmil...@gmail.com> Date: Fri, 18 May 2018 14:18:41 +0200
> In com20020.c found this: > /* FIXME: do this some other way! */ > if (!dev->dev_addr[0]) > dev->dev_addr[0] = arcnet_inb(ioaddr, 8); > > NODE-ID, must be univoque, for all arcnet network. > My previews idea was take random value but, this could create a > collision over network. > > A possible solution is: > In case of collision com20020 set a bit in status register. > Then peak a new NODE-ID and repeat this while correct NODE-ID is found. > > Other ideas is pass it via DTS. > But suppose have 2 same product in same network, same address same problem. > For this reason i prefer left standard driver behavior. > > Other ideas for solve this ? Is there no way to obtain a unique value from the device? If having a unique ID to talk on the ARCNET is so critical, there must be some way to properly allocation and use a unique ID. I guess this must be a general problem with this driver already. You still need to address the issue of 'dev' being leaked on probe error paths. Thank you.
