On Mon, May 14, 2018 at 7:07 PM, Willem de Bruijn
<willemdebruijn.ker...@gmail.com> wrote:
> From: Willem de Bruijn <will...@google.com>
>
> Until the udp receive stack supports large packets (UDP GRO), GSO
> packets must not loop from the egress to the ingress path.
>
> Revert the change that added NETIF_F_GSO_UDP_L4 to various virtual
> devices through NETIF_F_GSO_ENCAP_ALL as this included devices that
> may loop packets, such as veth and macvlan.
>
> Instead add it to specific devices that forward to another device's
> egress path: bonding and team.
>
> Fixes: 83aa025f535f ("udp: add gso support to virtual devices")
> CC: Alexander Duyck <alexander.du...@gmail.com>
> Signed-off-by: Willem de Bruijn <will...@google.com>
> ---> diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c > index 9dbd390ace34..c6a9f0cafea2 100644 > --- a/drivers/net/team/team.c > +++ b/drivers/net/team/team.c > @@ -1026,7 +1026,8 @@ static void __team_compute_features(struct team *team) > } > > team->dev->vlan_features = vlan_features; > - team->dev->hw_enc_features = enc_features | NETIF_F_GSO_ENCAP_ALL; > + team->dev->hw_enc_features = enc_features | NETIF_F_GSO_ENCAP_ALL | > + NETIF_GSO_UDP_L4; This has a typo. team.ko did not build automatically for me and caught it with a full compile just too late. Need to send a v2, sorry.
