From: Felix Manlunas <felix.manlu...@cavium.com> Date: Thu, 3 May 2018 19:23:25 -0700
> +static int lio_set_link_ksettings(struct net_device *netdev, > + const struct ethtool_link_ksettings *ecmd) > +{ > + struct lio *lio = GET_LIO(netdev); > + struct octeon_device *oct = lio->oct_dev; > + struct oct_link_info *linfo; > + const int speed = ecmd->base.speed; > + u32 is25G = 0; Please order local variable declarations from longest to shortest line, as was properly done in the rest of this patch. Thank you.