Hi Stephen, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/inet-add-bound-ports-statistic/20180503-182729 config: i386-randconfig-x000-201817 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> net/ipv4/inet_hashtables.c:62:14: error: conflicting types for >> 'inet_bind_bucket_count' unsigned int inet_bind_bucket_count(struct proto *prot) ^~~~~~~~~~~~~~~~~~~~~~ In file included from net/ipv4/inet_hashtables.c:26:0: include/net/inet_hashtables.h:199:5: note: previous declaration of 'inet_bind_bucket_count' was here int inet_bind_bucket_count(struct proto *prot); ^~~~~~~~~~~~~~~~~~~~~~ vim +/inet_bind_bucket_count +62 net/ipv4/inet_hashtables.c 60 61 /* Count how many any entries are in the bind hash table */ > 62 unsigned int inet_bind_bucket_count(struct proto *prot) 63 { 64 struct inet_hashinfo *hinfo = prot->h.hashinfo; 65 unsigned int i, ports = 0; 66 67 for (i = 0; i < hinfo->bhash_size; i++) 68 ports += hinfo->bhash[i].count; 69 70 return ports; 71 } 72 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip