From: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 16:23:46 -0400
> NAK. > > Some functions in the past didn't like getting hit rapidly in succession. > > I would agree to this, but only after an exhaustive audit of each driver > and each sub-ioctl. Right now, I only have confidence in GDRVINFO > probably being safe -- but still that requires an audit, since in rare > cases the driver may be poking firmware and eeprom areas. I think the purely software state ones are safe, such as GDRVINGO, GSG, GTSO, etc. This absolutely excludes things like PHYS_ID and GREGS which almost always have to touch the hardware. > Finally, I fixed a buffer overflow in ethtool version 5, so an audit to > make sure overflows cannot affect the kernel is basically _required_. Absolutely. I think we should put in Stephen's change with the obvious PHYS_ID and GREGS exceptions removed. We have a lot of time to make sure everything remaining is kosher for 2.6.19 ok? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
