> > When a band is created, it is set to the default qdisc, which is > > "invisible" pfifo. > > However, if a band is set to a qdisc that is later being deleted, it will > > be set to noop qdisc. This can cause a packet loss, while there is no clear > > user indication for it. ("invisible" qdisc are not being shown by default). > > This patch sets a band to the default qdisc, rather then the noop qdisc, on > > delete operation. > > > > Signed-off-by: Nogah Frankel <nog...@mellanox.com> > > Like Cong, I'm worried this will break something. The code has > behaved this way for 2 decades or longer. > > If you want to put another qdisc there, and thus not drop any traffic, > modify the qdisc to a new one instead of performing a delete operation.
I believe that this historic behavior is quite bug like, especially because TCA_DUMP_INVISIBLE is not set by default. Yet I accept your judgment that changing it now might break things. Thank you. Nogah