On Wed, Apr 18, 2018 at 1:50 PM, David Miller <da...@davemloft.net> wrote:
> From: Willem de Bruijn <willemdebruijn.ker...@gmail.com>
> Date: Tue, 17 Apr 2018 16:00:50 -0400
>
>> Segmentation offload reduces cycles/byte for large packets by
>> amortizing the cost of protocol stack traversal.
>>
>> This patchset implements GSO for UDP.
>
> This looks great.
>
> And as mentioned in other emails, the interface looks good too by letting
> the app choose the segmentation point.
>
> It's a real shame we lose checksumming with MSG_MORE, perhaps we can find
> a way to lift that restriction?
Actually, yes, I should be able to relax that constraint with
segmentation.
It is there in case a corked packet may grow to the point of
having to be fragmented. But segmentation already ensures
that its datagrams always fit in MTU.
Should be simple refinement to
!(flags & MSG_MORE) &&
in __ip_append_data.
