On Wed, 18 Apr 2018, Dominique Martinet wrote: > Jozsef Kadlecsik wrote on Wed, Apr 18, 2018: > > Thanks for the testing! One more line is required, however: we have to get > > the assured bit set for the connection, see the new patch below. > > I think it actually was better before. If I understand things correctly > at this point (when we get in the case TCP_CONNTRACK_SYN_RECV) we will > have seen SYN(out) SYN(in) SYNACK(out), but not the final ACK(in) yet. > > Leaving old state as it was will not set the assured bit, but that will > be set on the next packet because old_state == new_state == established > at that point and the connection will really be setup then.
Yes, you are right: the first patch is better than the second one. Overthinking :-) Best regards, Jozsef - E-mail : kad...@blackhole.kfki.hu, kadlecsik.joz...@wigner.mta.hu PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary
