On Tue, Apr 17, 2018 at 09:45:12AM -0400, David Miller wrote:
> From: Stefan Hajnoczi <stefa...@redhat.com>
> Date: Tue, 17 Apr 2018 14:25:58 +0800
>
> > Commit c1eef220c1760762753b602c382127bfccee226d ("vsock: always call
> > vsock_init_tables()") introduced a module_init() function without a
> > corresponding module_exit() function.
> >
> > Modules with an init function can only be removed if they also have an
> > exit function. Therefore the vsock module was considered "permanent"
> > and could not be removed.
> >
> > This patch adds an empty module_exit() function so that "rmmod vsock"
> > works. No explicit cleanup is required because:
> >
> > 1. Transports call vsock_core_exit() upon exit and cannot be removed
> > while sockets are still alive.
> > 2. vsock_diag.ko does not perform any action that requires cleanup by
> > vsock.ko.
> >
> > Reported-by: Xiumei Mu <x...@redhat.com>
> > Cc: Cong Wang <xiyou.wangc...@gmail.com>
> > Cc: Jorgen Hansen <jhan...@vmware.com>
> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
>
> Applied, but please provide a proper Fixes: tag next time. I added it
> for you this time.Will do. Thanks! Stefan
signature.asc
Description: PGP signature
