On 04/11/2018 06:48 PM, Jia-Ju Bai wrote: > b53_switch_reset_gpio() is never called in atomic context. > > The call chain ending up at b53_switch_reset_gpio() is: > [1] b53_switch_reset_gpio() <- b53_switch_reset() <- > b53_reset_switch() <- b53_setup() > > b53_switch_reset_gpio() is set as ".setup" in struct dsa_switch_ops. > This function is not called in atomic context. > > Despite never getting called from atomic context, b53_switch_reset_gpio() > calls non-sleep operations mdelay() and gpio_set_value(). > They are not necessary and can be replaced with msleep() > and gpio_set_value_cansleep(). > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1...@gmail.com>
Acked-by: Florian Fainelli <f.faine...@gmail.com> -- Florian
