bgmac_dma_tx_ring_free() assigns the ctl1 word which is a litle endian
32-bit word without using proper accessors, fix this, and because a
length cannot be negative, use unsigned int while at it.

Fixes: 9cde94506eac ("bgmac: implement scatter/gather support")
Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
---
 drivers/net/ethernet/broadcom/bgmac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bgmac.c 
b/drivers/net/ethernet/broadcom/bgmac.c
index 8eef9fb6b1fe..ad8195b0d161 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -533,7 +533,8 @@ static void bgmac_dma_tx_ring_free(struct bgmac *bgmac,
        int i;
 
        for (i = 0; i < BGMAC_TX_RING_SLOTS; i++) {
-               int len = dma_desc[i].ctl1 & BGMAC_DESC_CTL1_LEN;
+               u32 ctl1 = le32_to_cpu(dma_desc[i].ctl1);
+               unsigned int len = ctl1 & BGMAC_DESC_CTL1_LEN;
 
                slot = &ring->slots[i];
                dev_kfree_skb(slot->skb);
-- 
2.14.1

Reply via email to