On 3/29/18 12:11 PM, David Miller wrote: > From: Jakub Kicinski <jakub.kicin...@netronome.com> > Date: Tue, 27 Mar 2018 18:34:50 -0700 > >> On Tue, 27 Mar 2018 18:22:00 -0700, David Ahern wrote: >>> +void nsim_devlink_setup(struct netdevsim *ns) >>> +{ > ... >> nit: DaveM expressed preference to not have silent failures in a >> discussion about DebugFS, not sure it applies here, but why not >> handle errors? > > Yes it is a concern. > > David please address this as a follow-up.
Will do.