On 29 March 2018 at 17:41, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Thu, Mar 29, 2018 at 03:15:54PM +0200, Andreas Gruenbacher wrote: >> >> For all I know, Neil's latest plan is to get rhashtable_walk_peek >> replaced and removed because it is unfixable. This patch removes the >> one and only user. > > His latest patch makes rhashtable_walk_peek stable in the face of > removals. > > https://patchwork.ozlabs.org/patch/892534/
Ok, I can slightly update my patch description. The problem still remains that glocks can be deleted from the rhashtable between stop/start, and that needs to be fixed in gfs2. Once that's done, keeping track of the current glock comes for free and we won't need rhashtable_walk_peek anymore. Should rhashtable_walk_peek be kept around even if there are no more users? I have my doubts. Thanks, Andreas
