Hi David, Thanks for feedback.
On Tue, Mar 27, 2018 at 01:28:22PM -0400, David Miller wrote: > From: Vadim Lomovtsev <vadim.lomovt...@caviumnetworks.com> > Date: Tue, 27 Mar 2018 08:07:29 -0700 > > > From: Vadim Lomovtsev <vadim.lomovt...@cavium.com> > > > > By default CN88XX BGX accepts all incoming multicast and broadcast > > packets and filtering is disabled. The nic driver doesn't provide > > an ability to change such behaviour. > > > > This series is to implement DMAC filtering management for CN88XX > > nic driver allowing user to enable/disable filtering and configure > > specific MAC addresses to filter traffic. > > This doesn't even compile: > > drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function > ‘bgx_lmac_save_filter’: > drivers/net/ethernet/cavium/thunder/thunder_bgx.c:286:3: warning: ‘return’ > with no value, in function returning non-void [-Wreturn-type] > return; > ^~~~~~ > drivers/net/ethernet/cavium/thunder/thunder_bgx.c:281:12: note: declared here > static int bgx_lmac_save_filter(struct lmac *lmac, u64 dmac, u8 vf_id) > ^~~~~~~~~~~~~~~~~~~~ > In file included from drivers/net/ethernet/cavium/thunder/nic.h:15:0, > from drivers/net/ethernet/cavium/thunder/thunder_bgx.c:21: > drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function > ‘bgx_set_dmac_cam_filter_mac’: > drivers/net/ethernet/cavium/thunder/thunder_bgx.h:61:38: warning: left shift > count >= width of type [-Wshift-count-overflow] > #define RX_DMACX_CAM_LMACID(x) (x << 49) > ^ > drivers/net/ethernet/cavium/thunder/thunder_bgx.c:324:8: note: in expansion > of macro ‘RX_DMACX_CAM_LMACID’ > cfg = RX_DMACX_CAM_LMACID(lmacid & LMAC_ID_MASK) | > ^~~~~~~~~~~~~~~~~~~ Will update and repost series as v2. Do you have any other comments ? WBR, Vadim
