From: Roman Mashak <m...@mojatatu.com>
Date: Thu, 22 Mar 2018 18:00:25 -0400

> Collapse tca_get_notify(), tca_add_notify() and tca_del_notify() in a
> single function since they repeat the same code pattern.
> 
> Signed-off-by: Roman Mashak <m...@mojatatu.com>

This really doesn't improve the situation.

Instead of a couple clearly coded helpers, you now have one which is
bombed with conditionals that change it's behavior based upon the
event that gets passed in.

This is much less intuitive than how the code is now.

I'm not applying this, sorry.

Reply via email to