From: Saeed Mahameed <sae...@mellanox.com> Date: Thu, 22 Mar 2018 15:33:38 -0700
> +#if IS_ENABLED(CONFIG_TLS_DEVICE) > +DEFINE_STATIC_KEY_FALSE(clean_acked_data_enabled); > +EXPORT_SYMBOL_GPL(clean_acked_data_enabled); > +#endif Please mark this symbol static (otherwise it's name pollutes the global name space, "clean_acked" what? for what subsystem? etc.) And add two helper functions, icsk_clean_acked_enable() and icsk_clean_acked_disable() which adjust the static key as needed. For the enable helper, you can pass in an icsk and the function pointer, so that the helper can do the assignment and the connection between the static key and registering on an icsk is clear.
