On Tue, 19 Sep 2006 16:04:41 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote:
> From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Tue, 19 Sep 2006 16:02:02 -0700 > > > > > > When TCP_CONG_ADVANCED is disabled, TCP_CONG_BIC should always be set > > > and be the default, but that's not what the new code is doing. > > > > > > I'm reverting Stephen's patch (again) until this is all sorted > > > out as things are still broken in various ways even with the > > > followon patch. > > > > I don't see what's wrong, this is on a kernel with the two patches: > > Look more closely: > > > After "make defconfig" > > # CONFIG_TCP_CONG_ADVANCED is not set > > CONFIG_DEFAULT_TCP_CONG="bic" > > # CONFIG_NETFILTER_XT_MATCH_TCPMSS is not set > > # CONFIG_IP_NF_TARGET_TCPMSS is not set > > # CONFIG_ISCSI_TCP is not set > > But TCP_CONG_BIC isn't enabled so it won't get built nor be > the default algorithm. When CONG_ADVANCED is off, as it is here, > TCP_CONG_BIC should be "y". That's what happens before your > changes. Okay, build testing all the possibilities now, answer by morning.. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
