On Sat, 17 Mar 2018 12:52:26 +0530 Raju Rangoju <ra...@chelsio.com> wrote:
> +struct srq_data *t4_init_srq(int srq_size) > +{ > + struct srq_data *s; > + > + s = kzalloc(sizeof(*s), GFP_KERNEL | __GFP_NOWARN); > + if (!s) > + s = vzalloc(sizeof(*s)); > + if (!s) > + return NULL; I guess you could use kvzalloc() here. > [...] > > +++ b/drivers/net/ethernet/chelsio/cxgb4/srq.h > > [...] > > +enum { > + SRQ_WAIT_TO = (HZ * 5), > +}; Why not #define? Am I missing something? -- Stefano