>> + kfree(buf); free tb? buf is an array.
On Wed, Mar 14, 2018 at 8:25 AM, David Miller <da...@davemloft.net> wrote: > From: Arnd Bergmann <a...@arndb.de> > Date: Tue, 13 Mar 2018 21:58:39 +0100 > >> After the removal of the VLA, we get a harmless warning about a large >> stack frame: >> >> net/core/pktgen.c: In function 'pktgen_if_write': >> net/core/pktgen.c:1710:1: error: the frame size of 1076 bytes is larger than >> 1024 bytes [-Werror=frame-larger-than=] >> >> The function was previously shown to be safe despite hitting >> the 1024 bye warning level. To get rid of the annoyging warning, >> while keeping it readable, this changes it to use strndup_user(). >> >> Obviously this is not a fast path, so the kmalloc() overhead >> can be disregarded. >> >> Fixes: 35951393bbff ("pktgen: Remove VLA usage") >> Signed-off-by: Arnd Bergmann <a...@arndb.de> > > Applied, thanks.