Hi, Jakub Kicinski <kubak...@wp.pl> writes:
> On Tue, 6 Mar 2018 17:29:57 -0800, Vinicius Costa Gomes wrote: >> This allows filters added by tc-flower and specifying MAC addresses, >> Ethernet types, and the VLAN priority field, to be offloaded to the >> controller. >> >> This reuses most of the infrastructure used by ethtool, but clsflower >> filters are kept in a separated list, so they are invisible to >> ethtool. >> >> Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> > > LGTM, thanks! > >> + NL_SET_ERR_MSG(extack, > > One nit: consider using NL_SET_ERR_MSG_MOD to prefix the message with > driver name. Sure thing. Will send a v4 with this shortly. Cheers, -- Vinicius
