-----Original Message----- From: Arnd Bergmann [mailto:[EMAIL PROTECTED] Sent: Sunday, September 10, 2006 2:39 PM To: Misha Tomushev Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] VIOC: New Network Device Driver
Am Friday 15 September 2006 02:15 schrieb Misha Tomushev: > VIOC Device Driver provides a standard device interface to the internal > fabric interconnected network used on servers designed and built by > Fabric 7 Systems. > > The patch can be found at ftp.fabric7.com/VIOC. We recently had a discussion about tx descriptor cleanup in general. It would probably be more efficient to call vnic_clean_txq from the vioc_rx_poll() function. To do that, your tx interrupt handler should disable the tx interrupt line and call netif_rx_schedule, like you do for the receive interrupts. The descriptor clean-up does not contribute anything to the performance of the driver, it just replenishes the memory pools. It almost does not need interrupts. Why would we want to add more cycles to the receive logic, when driver is doing useful work for something that can run almost at any time? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
