On Wed, Feb 28, 2018 at 11:36:09AM -0800, Florian Fainelli wrote: > In order to remove a fair amount of duplication in the different 10G PHY > drivers, export all gen10g_* functions to be able to make use of those.
The gen10g functions tend to be barely functional - for example, gen10g_soft_reset() doesn't do the soft-reset thing, which could be argued to be a bug, as there's a generic way to do that. However, doing that for the Marvell 10G driver would be a big mistake. The PHY crashes if you try to set the reset bit in any of the control register 1s. -- Russell King
