From: David Ahern <dsah...@gmail.com>
Date: Sun, 25 Feb 2018 11:47:12 -0800

> A later patch removes rt6i_table from rt6_info. Save the ipv6
> table for a VRF in net_vrf. fib tables can not be deleted so
> no reference counting or locking is required.
> 
> Signed-off-by: David Ahern <dsah...@gmail.com>

Is this change really OK all by itself?

Sure, you fix up the vrf code operating on such 'rt6' objects to
not dereference the ->rt6i_table.

But any other code whatsoever that looks at this rt6 object (dumping,
other operations in the ipv6 stack data or control plane, etc.) can
legitimately expect always to see a non-NULL value here.

I really don't see how this can be OK and leave your patch series
properly bisectable.

Thanks.

Reply via email to