From: Ilya Lesokhin <il...@mellanox.com> Date: Mon, 5 Feb 2018 20:18:32 +0200
> Avoid SKB coalescing if eor bit is set in one of the relevant > SKBs. > > Fixes: c134ecb87817 ("tcp: Make use of MSG_EOR in tcp_sendmsg") > Signed-off-by: Ilya Lesokhin <il...@mellanox.com> This adds a build warning, please fix: CC net/ipv4/tcp_output.o In file included from ./include/linux/tcp.h:21:0, from ./include/net/tcp.h:24, from net/ipv4/tcp_output.c:39: net/ipv4/tcp_output.c: In function ‘tcp_write_xmit’: ./include/linux/skbuff.h:3196:12: warning: ‘skb’ may be used uninitialized in this function [-Wmaybe-uninitialized] for (tmp = skb->next; \ ^ net/ipv4/tcp_output.c:2043:18: note: ‘skb’ was declared here struct sk_buff *skb, *nskb, *next; ^~~ This is with: [davem@dhcp-10-15-49-227 net]$ gcc --version gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2) Copyright (C) 2017 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. [davem@dhcp-10-15-49-227 net]$