On Wed, 2006-06-09 at 09:38 +1000, Herbert Xu wrote: > On Sat, Sep 02, 2006 at 09:43:02AM -0400, jamal wrote: > > > > Allow for searching the SAD from external data path points without > > assumming L3 details. The only customer of this exposure currently > > is pktgen. > > Any reason why xfrm_state_find can't be used?
xfrm_state_find is overkill (if you compare the two functionalities). > It doesn't look right > to add generic code that's only used by pktgen. The alternative would require heavy mods to xfrm_state_find to do the minimal needed (a lot more than what i was asking for in mode output). I could move the function to outside of xfrm_state.c but that would require a few exports for it to use which looks less fair to me ;-> cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html