On Wed, 2018-01-24 at 14:45 -0800, Jeff Kirsher wrote: > This fixes a few warnings found by checkpatch.pl --strict [] > diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c > b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c [] > @@ -353,7 +353,7 @@ int fm10k_iov_resume(struct pci_dev *pdev) > struct fm10k_vf_info *vf_info = &iov_data->vf_info[i]; > > /* allocate all but the last GLORT to the VFs */ > - if (i == ((~hw->mac.dglort_map) >> FM10K_DGLORTMAP_MASK_SHIFT)) > + if (i == (~hw->mac.dglort_map >> FM10K_DGLORTMAP_MASK_SHIFT))
Strictly, only the if needs parentheses here, but I think it reads better before this change. > @@ -511,7 +511,7 @@ int fm10k_iov_configure(struct pci_dev *pdev, int num_vfs) > return err; > > /* allocate VFs if not already allocated */ > - if (num_vfs && (num_vfs != current_vfs)) { > + if (num_vfs && num_vfs != current_vfs) {