Hi Daniel, Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master] [also build test ERROR on v4.15 next-20180126] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Daniel-Axtens/bnx2x-disable-GSO-on-too-large-packets/20180131-000934 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=ia64 All errors (new ones prefixed by >>): In file included from include/linux/linkage.h:7:0, from include/linux/kernel.h:7, from include/linux/list.h:9, from include/linux/module.h:9, from net//core/skbuff.c:41: >> net//core/skbuff.c:4968:19: error: 'skb_gso_validate_network_len' undeclared >> here (not in a function); did you mean 'skb_gso_validate_mac_len'? EXPORT_SYMBOL_GPL(skb_gso_validate_network_len); ^ include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL' extern typeof(sym) sym; \ ^~~ net//core/skbuff.c:4968:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL' EXPORT_SYMBOL_GPL(skb_gso_validate_network_len); ^~~~~~~~~~~~~~~~~ vim +4968 net//core/skbuff.c 4954 4955 /** 4956 * skb_gso_validate_mtu - Return in case such skb fits a given MTU 4957 * 4958 * @skb: GSO skb 4959 * @mtu: MTU to validate against 4960 * 4961 * skb_gso_validate_mtu validates if a given skb will fit a wanted MTU 4962 * once split. 4963 */ 4964 bool skb_gso_validate_mtu(const struct sk_buff *skb, unsigned int mtu) 4965 { 4966 return skb_gso_size_check(skb, skb_gso_network_seglen(skb), mtu); 4967 } > 4968 EXPORT_SYMBOL_GPL(skb_gso_validate_network_len); 4969 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip