On Sun, Jan 28, 2018 at 8:48 PM, Christoph Paasch <cpaa...@apple.com> wrote:
> Commit 03aef17bb79b ("devinet_ioctl(): take copyin/copyout to caller")
> introduced a regression when using ifconfig. ifconfig doesn't show the
> address anymore. The reason is that the above patch changed the flow in
> devinet_ioctl(), where we break; and end up returning ret. ret however
> is set to -EADDRNOTAVAIL, which later on prevents the copy_to_user() in
> inet_ioctl().
>
> Thus, when we break in devinet_ioctl() we have to set ret to 0 to
> properly return out of devinet_ioctl.
>
> Cc: Al Viro <v...@zeniv.linux.org.uk>
> Cc: Christoph Hellwig <h...@lst.de>
> Fixes: 03aef17bb79b ("devinet_ioctl(): take copyin/copyout to caller")
> Signed-off-by: Christoph Paasch <cpaa...@apple.com>
> ---
> net/ipv4/devinet.c | 4 ++++
> 1 file changed, 4 insertions(+)
Oh, I hadn't seen that a fix was already posted this morning at
https://patchwork.ozlabs.org/patch/866817/.
You can disregard this patch here. Sorry for the noise.
Christoph
