On Mon, 04 Sep 2006 17:42:27 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> This fixes sky2 driver on big endian machines. I choose not to use the > hardware byteswap facility as it would have required to have a different > definition of the various ring data structures and it looks ugly :) On > powerpc, there is pretty much no overhead at doing byteswap. > > The patch has a couple of places where I reversed 2 assignments, they > are harmless, it was before I figured out that the chip will > (apparently) not access a descriptor before it's been told to do so via > MMIO, and thus the order of the writes to the descriptors is irrelevant > (I was also adding wmb's though I removed them). I'll put a minimized version of this in the next patch set. There is no need to re order assignments. > > There is a couple of places where we were doing a BE and not LE > conversion of a descriptor field (typically in the VLAN code). I'm not > sure what's up there but BE "felt" wrong. I have turned them into LE > conversions but then I haven't tested VLAN, and I might just > misudnerstand what's happening there so I'll let you decide what to do > about those. > > Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> It may not need any swapping, it is hard to tell what the hardware will do without experimentation. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
