Hi,
On Wed, Jan 17, 2018 at 8:27 PM, Jakub Kicinski <kubak...@wp.pl> wrote:
> On Wed, 17 Jan 2018 17:40:27 -0500, Alexander Aring wrote:
>> diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
>> index 8840baa1b9b4..daeac7282387 100644
>> --- a/net/sched/cls_u32.c
>> +++ b/net/sched/cls_u32.c
>> @@ -524,8 +524,10 @@ static int u32_replace_hw_hnode(struct tcf_proto *tp,
>> struct tc_u_hnode *h,
>> offloaded = true;
>> }
>>
>> - if (skip_sw && !offloaded)
>> + if (skip_sw && !offloaded) {
>> + NL_SET_ERR_MSG(extack, "Failed to offload filter requested
>> with skip sw");
>> return -EINVAL;
>> + }
>>
>> return 0;
>> }
>
> Why did you ignore my comment about using NL_SET_ERR_MSG_MOD? Do you
> disagree with it?
Sorry, I missed it I will add this. Thanks.
- Alex
