Although this issue is harmless since that code path is protected by the check on l2tp_nl_cmd_ops[]/l2tp_nl_cmd_ops[]->session_create(), fix error handling for L2TP_PWTYPE_IP/default case in l2tp_nl_cmd_session_create()
Signed-off-by: Lorenzo Bianconi <lorenzo.bianc...@redhat.com> --- net/l2tp/l2tp_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c index e1ca29f79821..48b5bf30ec50 100644 --- a/net/l2tp/l2tp_netlink.c +++ b/net/l2tp/l2tp_netlink.c @@ -635,7 +635,7 @@ static int l2tp_nl_cmd_session_create(struct sk_buff *skb, struct genl_info *inf case L2TP_PWTYPE_IP: default: ret = -EPROTONOSUPPORT; - break; + goto out_tunnel; } ret = l2tp_nl_cmd_ops[cfg.pw_type]->session_create(net, tunnel, -- 2.13.6