From: Jiri Pirko <j...@resnulli.us>
Date: Thu, 11 Jan 2018 11:20:58 +0100

> From: Yuval Mintz <yuv...@mellanox.com>
> 
> Add rdpm definition - router DSCP to priority mapping register.
> 
> Signed-off-by: Yuval Mintz <yuv...@mellanox.com>
> Signed-off-by: Nogah Frankel <nog...@mellanox.com>
> Signed-off-by: Jiri Pirko <j...@mellanox.com>

This doesn't explain why adding a definition for this register...

> @@ -42,7 +42,7 @@
>  
>  struct mlxsw_item {
>       unsigned short  offset;         /* bytes in container */
> -     unsigned short  step;           /* step in bytes for indexed items */
> +     short           step;           /* step in bytes for indexed items */
>       unsigned short  in_step_offset; /* offset within one step */
>       unsigned char   shift;          /* shift in bits */
>       unsigned char   element_size;   /* size of element in bit array */

requires making mlxsw_item->step signed.

Please update the commit message or move this change into a more
appropriate patch in this series or even a new one.  Whichever
is required.

Thanks.

Reply via email to