From: Neil Horman <nhor...@tuxdriver.com> Date: Wed, 3 Jan 2018 09:44:15 -0500
> A few spots in 3c59x missed calls to dma_mapping_error checks, casuing > WARN_ONS to trigger. Clean those up. While we're at it, refactor the > refill code a bit so that if skb allocation or dma mapping fails, we > recycle the existing buffer. This prevents holes in the rx ring, and > makes for much simpler logic > > Note: This is compile only tested. Ted, if you could run this and > confirm that it continues to work properly, I would appreciate it, as I > currently don't have access to this hardware > > Signed-off-by: Neil Horman <nhor...@redhat.com> > CC: Steffen Klassert <klass...@mathematik.tu-chemnitz.de> > CC: "David S. Miller" <da...@davemloft.net> > Reported-by: tedheads...@gmail.com See my other reply. Your RX handling must become more sophisticated. This is exactly what we tell driver authors to do. If you cannot allocate or DMA map a replacement RX buffer, you _MUST_ recycle the existing buffer back to the chip rather than pass it up to the stack. Thank you.
