"iwconfig key [x]" behavior is not correctly handled in the stack, also modify the giwencode method to show the key info.
Thanks, Hong
[PATCH]d80211: fix "iwconfig key [x]" behavior Signed-off-by: Hong Liu <[EMAIL PROTECTED]> diff --git a/net/d80211/ieee80211_ioctl.c b/net/d80211/ieee80211_ioctl.c index dd52555..d3dc59c 100644 --- a/net/d80211/ieee80211_ioctl.c +++ b/net/d80211/ieee80211_ioctl.c @@ -2811,9 +2811,10 @@ static int ieee80211_ioctl_siwencode(str if (sdata->default_key == NULL) idx = 0; else for (i = 0; i < NUM_DEFAULT_KEYS; i++) { - if (sdata->default_key == sdata->keys[i]) + if (sdata->default_key == sdata->keys[i]) { idx = i; - break; + break; + } } if (idx < 0) return -EINVAL; @@ -2824,16 +2825,22 @@ static int ieee80211_ioctl_siwencode(str alg = ALG_NONE; else if (erq->length == 0) { /* No key data - just set the default TX key index */ - sdata->default_key = sdata->keys[idx]; + if (sdata->default_key != sdata->keys[idx]) { + if (sdata->default_key) + ieee80211_key_sysfs_remove_default(sdata); + sdata->default_key = sdata->keys[idx]; + if (sdata->default_key) + ieee80211_key_sysfs_add_default(sdata); + } + return 0; } return ieee80211_set_encryption( dev, bcaddr, - idx, erq->length == 0 ? ALG_NONE : ALG_WEP, + idx, alg, sdata->default_key == NULL, NULL, keybuf, erq->length); - return 0; } @@ -2852,9 +2859,10 @@ static int ieee80211_ioctl_giwencode(str if (sdata->default_key == NULL) idx = 0; else for (i = 0; i < NUM_DEFAULT_KEYS; i++) { - if (sdata->default_key == sdata->keys[i]) + if (sdata->default_key == sdata->keys[i]) { idx = i; - break; + break; + } } if (idx < 0) return -EINVAL; @@ -2869,7 +2877,8 @@ static int ieee80211_ioctl_giwencode(str return 0; } - erq->length = 0; + erq->length = sdata->keys[idx]->keylen; + memcpy(key, sdata->keys[idx]->key, erq->length); erq->flags |= IW_ENCODE_ENABLED; return 0;