On Wed, 27 Dec 2017 13:28:13 +0200 Serhey Popovych <serhe.popov...@gmail.com> wrote:
> In this series I present next set of improvements/fixes: > > 1) Fix noencap- option handling: we need to clear bit, instead > of seting all, but one we expect to clear. > > 2) Document "external" parameter both in ip-link(8) and help > output for link_gre.c. Add "noexternal" option variant to > bring inline with GENEVE and VXLAN. > > 3) Trivial: clear flowlabel/tclass from flowinfo in case of > inherit to stop sending garbage to the kernel. It has no > functional change, but follows similar behaviour in link_ip6tnl.c > > See individual patch description message for details. > > Thanks, > Serhii > > Serhey Popovych (3): > gre,ip6tnl/tunnel: Fix noencap- support > gre6/tunnel: Do not submit garbage in flowinfo > ip/tunnel: Document "external" parameter > > ip/link_gre.c | 7 +++++-- > ip/link_gre6.c | 4 ++-- > ip/link_ip6tnl.c | 6 ++++-- > ip/link_iptnl.c | 4 +++- > man/man8/ip-link.8.in | 6 ++++++ > 5 files changed, 20 insertions(+), 7 deletions(-) > These are really disjoint. I applied the noencap and the flowinfo patch. Agree with William that having noexternal which does nothing useful is of little value now.