On Sat, Dec 23, 2017 at 1:04 AM, Sergei Shtylyov
<[email protected]> wrote:
> Hello!
>
> On 12/22/2017 06:37 PM, Yafang Shao wrote:
>
>> There's a space character missed in the printk messages.
>> This error should be prevented with checkscript.pl, but it couldn't caught
>
> ^ be?
It is checkpatch.pl.
>
>> by running with "checkscript.pl -f xxxx.patch", that's what I had run
>> before.
>> What a carelessness.
>
>
> You generally don't need to break up the messages violating 80-column
> limit, and checkpatch.pl should be aware of this...
>
Oh. That's right.
It can be aware of that.
I just want to make the code easy to read and limit the textwidth to
80 character.
If the message takes two lines as bellow,
printk("xxx "
^ space character.
"yyy");
The checkpatch.pl could also be aware of that if the first line is
not end with space character, but it couldn't be aware of that if run
with "checkpatch.pl -f xxxx.patch".
>> Fixes: 563e0bb0dc74("net: tracepoint: replace tcp_set_state tracepoint
>> with
>> inet_sock_set_state tracepoint")
>> Signed-off-by: Yafang Shao <[email protected]>
>
> [...]
>
> MBR, Sergei
