On 12/22/2017 12:24 AM, Yanjun Zhu wrote:
On 2017/12/20 8:00, Shannon Nelson wrote:
If the skb has a security association referenced in the skb, then
set up the Tx descriptor with the ipsec offload bits. While we're
here, we fix an oddly named field in the context descriptor struct.
[...]
+int ixgbe_ipsec_tx(struct ixgbe_ring *tx_ring,
+ struct ixgbe_tx_buffer *first,
+ struct ixgbe_ipsec_tx_data *itd)
+{
+ struct ixgbe_adapter *adapter = netdev_priv(tx_ring->netdev);
+ struct ixgbe_ipsec *ipsec = adapter->ipsec;
+ struct xfrm_state *xs;
+ struct tx_sa *tsa;
+
+ if (!first->skb->sp->len) {
Hi, Nelson
The function ixgbe_ipsec_tx is called in tx fastpath. Can we add
unlikely as below:
if (unlikely(!first->skb->sp->len)) ?
If I am wrong, please correct me.
Thanks a lot.
Zhu Yanjun
Yes, we can probably throw those in. I'll be working on this code in
the new year to get the checksum and TSO bits working and can add these
at that time.
sln
