Am 22.12.2017 um 10:57 schrieb Andrew Lunn: > On Thu, Dec 21, 2017 at 09:50:28PM +0100, Heiner Kallweit wrote: >> Use genphy_soft_reset instead of open coding the soft reset. > > Hi Heiner > > At this point, you have swapped over the phylib. Does one of the > drivers in drivers/net/phy now take control of the PHY? Does the PHY > ID match one of those in realtek.c? > > The PHY driver and phylib should be responsible for resetting the > PHY. The MAC driver should not need to do this. > In my case the PHY ID matches the existing RTL8211E driver in realtek.c and the MAC driver wouldn't have to do any soft reset.
However there may be chips with a PHY ID not yet being supported by realtek.c. AFAICS in such a case phylib uses genphy_driver which has a no-op soft reset. Therefore I'd tend to say that we can remove the phy soft reset from MAC driver only after being sure that all PHY ID's of supported NIC's have a driver in realtek.c. > Andrew > Heiner By the way: Thanks for the review comments.
